Skip to content

Commit

Permalink
revert: build(deps): update cadvisor to v0.47.2
Browse files Browse the repository at this point in the history
This reverts commit 46dd363.
  • Loading branch information
nightah committed Jun 26, 2023
1 parent 0966f5f commit 76a5131
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docker-compose.exporters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ services:
org.label-schema.group: "monitoring"

cadvisor:
image: gcr.io/cadvisor/cadvisor:v0.47.2
image: gcr.io/cadvisor/cadvisor:v0.47.1
container_name: cadvisor
privileged: true
devices:
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ services:
org.label-schema.group: "monitoring"

cadvisor:
image: gcr.io/cadvisor/cadvisor:v0.47.2
image: gcr.io/cadvisor/cadvisor:v0.47.1
container_name: cadvisor
privileged: true
devices:
Expand Down

4 comments on commit 76a5131

@kroese
Copy link

@kroese kroese commented on 76a5131 Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nightah Why was this reverted? Just curious..

@nightah
Copy link
Collaborator Author

@nightah nightah commented on 76a5131 Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kroese the manifest didn't exist at the time of publishing so the image could not be pulled.

@kroese
Copy link

@kroese kroese commented on 76a5131 Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nightah Okay, that makes sense. Because I am using v0.47.2 for many months already without any issues. So when I saw that you reverted back to v0.47.1 I was a little bit worried that you may have found some compability issue for example.

@nightah
Copy link
Collaborator Author

@nightah nightah commented on 76a5131 Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updated all deps now so you'll be able to pull in the changes shortly, this change is also not reincluded.

Please sign in to comment.