[Feat] Bump walk-sync; Add support for walk-sync opts #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 26, 2018 16:40
- Bump walk-sync to 0.3.3. - The latest version of walk-sync has options for selectively including or excluding files and directories. Add a parameter to tree-sync through which these options can be passed in and passed along to walk-sync. Only whitelisted options `globs` and `ignore` are passed through. - Add a typings file for tree-sync and include in package.json. Resolves stefanpenner#18 and stefanpenner#19.
Would you mind separating this change into a separate PR? It seems unrelated to the majority of the work here, and I don't want to hold things up just for that... |
rwjblue
reviewed
Nov 27, 2018
|
Thanks for the feedback. I'll update the PR to spin off the typings into a new PR and update the readme. |
timlindvall
changed the title
|
i like it! |
|
released as v1.3.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globsandignoreare passed through.Resolves #19.
Notes:
globs, since it can be easy to run into some pitfalls with missing dirs using that option. In the end, I leaned towards including it for completeness and adding a warning of what to watch out for. If we'd rather stick to excluding only, let me know and I'll update.Thanks in advance for the review!
(updated to reflect typings being spun off into their own PR)