Cache column option #654
Merged
Cache column option #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boolean flag was redundant for the column Have kept the previous option available, but included a deprecation message has_ancestry :cache_depth => "ancestry_depth2" has_ancestry :cache_depth => true # "ancestry_depth2" deprecated: has_ancestry :cache_depth => true, :depth_cache_column => "ancestry_depth2"
a. don't define dynamic methods that will just raise an exception. b. simpler to just define the scopes by hand than with a loop
The main reason I introduced depth sql is to improve rebuild_depth_cache_sql! Throwing this into the scopes is a bonus. (but not really) This works great for the update, but the extra scopes will not perform well. If you need to use them, consider adding an index on that equation
Use math to adjust the depth_cache instead of re-calculating the depth I had wanted to use ancestry_depth_sql, but that was using the ancestry value and putting in the new ancestry value would have been too complicated goal: remove the regular expression
In our code, if the functionality depends upon the ancestry format, we need to move that into the format modules
kbrock
force-pushed
the
cache_column_option
branch
from
42f99fa
to
963c1ea
Compare
This was referenced Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_depth_cache_sql!is a faster version ofbuild_depth_cache. Considering dropping the ruby version.ancestry_formatcache_depthanddepth_cache_columnoptions. Unsure which one we should usedepth_cache(though you should only use that for background jobs because it will surely do a full table scan)