Repository navigation
Fixed replacing whole document - #15
Merged
Merged
Conversation
- json pointer to_last operation returns None for the part in the case that it is a whole document pointer - json patch now checks to see if the part is None and simply returns the value to replace the document - Added a test to verify the fix
Owner
|
Looks good at first glance. I'll have a closer look and merge later. Would you mind adding your test also to json-patch/json-patch-tests? |
Contributor
Author
|
I just submitted json-patch/json-patch-tests/pull/9 I guess you're a contributor for that repo as well, but I ran that test from there against master and the fix I submitted and it has the same result. Thanks. |
Owner
|
Thanks, I've just released version 1.1 with that fix. |
Contributor
Author
|
Thanks for releasing the pypi version so quickly it will save me from cloning it from the git repo. |
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
case that it is a whole document pointer
the value to replace the document