#119 #120 Fix make_patch() to avoid casting numeric string to int on item moved #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be an issue with a pypy build, but that seems unrelated to your pull request. I will have a closer look in the next days. |
|
Thanks 🙌 |
stefankoegl
requested changes
Feb 17, 2021
jsonpatch.py
Outdated
Comment on lines
803
to
806
| if type(op.key) == int: | ||
| added_item = op.pointer.to_last(self.dst_doc)[0] | ||
| if type(added_item) == list: |
There was a problem hiding this comment.
Could you please just add a comment here to clarify for posterity?
There was a problem hiding this comment.
I've done so now. Please let me know if there's anything else I should add in the comment. It was a bit difficult to express what the _on_undo_add call accomplishes and I think it'd be valuable to mention that.
There was a problem hiding this comment.
@stefankoegl kind reminder on this
|
Thanks :) |
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #119 #120