Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Don't track _version.py #147

Merged
merged 2 commits into from
Nov 27, 2022
Merged

Conversation

MBounouar
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 88.09% // Head: 88.09% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1565fa0) compared to base (d4f77b5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   88.09%   88.09%   -0.01%     
==========================================
  Files         172      171       -1     
  Lines       16166    16164       -2     
==========================================
- Hits        14242    14240       -2     
  Misses       1924     1924              

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefan-jansen
Copy link
Owner

Hey @MBounouar, why do you want to delete _version.py? zipline/__init__.py uses it to determine the version number.

@MBounouar
Copy link
Author

Hey @MBounouar, why do you want to delete _version.py? zipline/__init__.py uses it to determine the version number.

Hi, I thought it was obvious from the comment generated by setuptools_scm that it wasn't necessary to track it as it is re-created new at every new installation

@stefan-jansen stefan-jansen merged commit c48b9d8 into stefan-jansen:main Nov 27, 2022
@MBounouar MBounouar deleted the patch-1 branch January 20, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants