adding endianness, radix, and bitness; fixing external file updates and few other small bugs; #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
details: * Enabled endianness of displayed data (the main reason behind the change) enabled by the added feature to hexy.js * Context Menu: added convenient switch of displaying between 1, 2, 4 and 8 byte words * New Functionality: added ability to display bytes as binary, octal, decimal and hexadecimal * Context Menu: the above functionality is also accessible via the context menu * Bugfix: endiannes was always set to "big", regardless of the UI setting in multi-byte displaying * Bugfix: fixed the meaning of endiannes that was incorrectly displayed in the status bar * Bugfix: the popup tooltip was showing value of the sequence starting with the byte under cursor, as opposed to the value displayed under the cursor. This change doesn't affect the 2-nibble (one byte) display mode (need before and after screenshots) * Build: fixed build by providing `null` arguments into `resolve()` -- the method requires one argument now * Dependency: now depending on hexy.js 0.3.3 (unpublished yet), which supports endianness and radix * Version: updated version number
… distribution) version of the plugin
…itness/radix/endianness modes
…le changes) and the clipboard. Also, added a bit of consistency
before this change, the list of known files always grew. Meaning if the file is closed, its data persisted in the memory, but wasn't updated when it was updated externally. Fixed it two ways: first, re-reading the whole file on every change, and removing the file from `_files` on tab closure
also, furhter reduced the number of dependencies, by removing sprintf-js KNOWN ISSUE: the decorations (i.e. showing edited values) are displayed incorrectly in the following 2 cases: * when littleEndian is on * after changing bittness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
details:
nullarguments intoresolve()-- the method requires one argument nowclipboardly,sprintf-js, and nativefsobjects -- replaced by vscode's alternatives that work better (some of the bugfixes above are attributed to this)