Merged
Conversation
cyon1c
approved these changes
Jan 26, 2018
Contributor
cyon1c
left a comment
cyon1c
left a comment
There was a problem hiding this comment.
Approving.
Suggestion that we remove some magic numbers like (56060*24) and replace with global constants to provide more human readable code.
Dont-Copy-That-Floppy
pushed a commit
to Dont-Copy-That-Floppy/steem-python
that referenced
this pull request
Feb 23, 2025
Corrected sp_to_rshares math
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found I was getting incorrect results based on this method, so I dug into the code in steemit/steem, and discovered the math was being done improperly.
https://github.com/steemit/steem/blob/8cd5f688d75092298bcffaa48a543ed9b01447a6/libraries/chain/steem_evaluator.cpp#L1169-L1190
I believe this pull request contains what the math should be to derive proper rshares for a given amount of SP.