Skip to content

Add regenerated VP to VP on last vote on account.voting_power() method#102

Closed
emre wants to merge 1 commit intosteemit:masterfrom
emre:fix-vp
Closed

Add regenerated VP to VP on last vote on account.voting_power() method#102
emre wants to merge 1 commit intosteemit:masterfrom
emre:fix-vp

Conversation

@emre
Copy link

@emre emre commented Nov 16, 2017

@codewithcheese
Copy link

This would be a breaking change for those using the value in their own calculation of the current voting power. Would be better as a new method, like current_voting_power()

@crokkon
Copy link
Contributor

crokkon commented Jan 24, 2018

I think you need .total_seconds() instead of .seconds? .seconds will be wrong if the difference is larger than a day. Also it will give values >100% if the last vote is long enough in the past

@emre
Copy link
Author

emre commented Jan 24, 2018

Agreed both of your points. @codewithcheese @crokkon.

However, I don't mind to fix it right now since nobody in the projects reviews these. Closing this.

@emre emre closed this Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants