Skip to content

Commit

Permalink
update stable vscode target to 1.59
Browse files Browse the repository at this point in the history
  • Loading branch information
brettfo authored and colombod committed Aug 3, 2021
1 parent aa19c64 commit 22ee24a
Show file tree
Hide file tree
Showing 14 changed files with 1,355 additions and 503 deletions.
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -394,5 +394,3 @@ src/Microsoft.DotNet.Interactive.SandDance.js/dist/
src/Microsoft.DotNet.Interactive.Mermaid.js/dist/

src/Microsoft.DotNet.Interactive.ExtensionLab.Tests/DataFrameKernelExtensionTests.it_registers_formatters.received.json

src/dotnet-interactive-vscode/insiders/resources/kernelApiBootstrapper.js
2 changes: 2 additions & 0 deletions NotebookTestScript.dib
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ var x = 123;
The value is 123.
```

And the output below the next cell should display the same value.

#!javascript

const x = await interactive.csharp.getVariable("x");
Expand Down
1 change: 1 addition & 0 deletions src/dotnet-interactive-vscode/.gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
dotnet-interactive-*.vsix
kernelApiBootstrapper.js
6 changes: 3 additions & 3 deletions src/dotnet-interactive-vscode/insiders/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"//version": "The version '42.42.42' is auto-set during CI package creation.",
"version": "42.42.42",
"engines": {
"vscode": "1.59.0-insider"
"vscode": "1.60.0-insider"
},
"bugs": {
"url": "https://github.com/dotnet/interactive/issues"
Expand Down Expand Up @@ -134,7 +134,7 @@
},
"dotnet-interactive.minimumInteractiveToolVersion": {
"type": "string",
"default": "1.0.235701",
"default": "1.0.238006",
"description": "The minimum required version of the .NET Interactive tool."
},
"dotnet-interactive.logLevel": {
Expand Down Expand Up @@ -468,4 +468,4 @@
"node-fetch": "2.6.1",
"uuid": "8.3.2"
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
Updating to new version of stable
=================================

1. `.\update-api.ps1`
2. Copy `insiders\package.json` to `stable\`
3. Copy `insiders\src\*` to `stable\src\*` **EXCEPT** for the `common` symlinked directory.
4. Update verion number in `vscodeStableVersion.txt`
5. `git add .`, `git commit`
6. `.\update-api.ps1`
7. `.\update-versions.ps1 -updateAll`
8. Verify there are no surprises in the changes between steps 6 and this.

At this point `stable\src\vscode.d.ts` (and `vscode.proposed.d.ts`) will exactly equal the files in `insiders\src`.

Validating
==========

1. Use VSCode - Insiders to test the `stable` version of the code. Go through all scenarios in the `NotebookTestScript.dib` file at the root of the repo.
2. Use VSCode - Insiders to test the `insiders` version of the code, exactly as above **EXCEPT** you'll have to manually drop the `engines.vscode` value in `package.json`
since that version of Insiders doesn't exist yet.
Loading

0 comments on commit 22ee24a

Please sign in to comment.