-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add @stdlib/blas/base/drotg
#929
Conversation
I guess, I have a lint error in |
All tests and benchmarks cleared, this PR can have a review. |
@Pranavchiku Would you be willing to update this PR according to the changes made in commit 36b75b3? |
@Pranavchiku When getting mixed tabs and spaces lint errors, in Sublime Text, I simply select all text and then use built in IDE tools to convert indentation from spaces to tabs (or vice versa depending on the file type). In short, prefer resolving this locally rather than using |
lib/node_modules/@stdlib/blas/base/drotg/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/base/drotg/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pranavchiku This mostly looks good. The tests need some refactoring.
Updated tests, all tests pass and benchmarks cleared, this PR can have a final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @Pranavchiku!
drotg
routine@stdlib/blas/base/drotg
Fixes #279.
Checklist
@kgryte
Reference
drotg
implementation: netlib