Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @stdlib/blas/base/drotg #929

Merged
merged 27 commits into from
Mar 2, 2023
Merged

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Feb 26, 2023

Fixes #279.

Checklist

  • Add readme.md
  • repl.txt
  • types
  • package.json
  • lib
  • examples
  • benchmark
  • test

@kgryte


Reference drotg implementation: netlib

@Pranavchiku
Copy link
Member Author

I guess, I have a lint error in test.assign.js and test.main.js, that was some mixed space and tab indents, I was unable to fix it hence used --no-verify commit, will polish it once all files get in this PR.

@Pranavchiku
Copy link
Member Author

All tests and benchmarks cleared, this PR can have a review.

@Pranavchiku Pranavchiku marked this pull request as ready for review February 28, 2023 17:40
@kgryte
Copy link
Member

kgryte commented Mar 1, 2023

@Pranavchiku Would you be willing to update this PR according to the changes made in commit 36b75b3?

@kgryte kgryte added Feature Issue or pull request for adding a new feature. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). labels Mar 1, 2023
@kgryte
Copy link
Member

kgryte commented Mar 1, 2023

@Pranavchiku When getting mixed tabs and spaces lint errors, in Sublime Text, I simply select all text and then use built in IDE tools to convert indentation from spaces to tabs (or vice versa depending on the file type). In short, prefer resolving this locally rather than using --no-verify.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranavchiku This mostly looks good. The tests need some refactoring.

@Pranavchiku
Copy link
Member Author

Updated tests, all tests pass and benchmarks cleared, this PR can have a final review.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Pranavchiku!

@kgryte kgryte changed the title feat: add support for BLAS Level 1 drotg routine feat: add @stdlib/blas/base/drotg Mar 2, 2023
@kgryte kgryte merged commit 85d9810 into stdlib-js:develop Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: add BLAS Level 1 drotg routine
2 participants