-
-
Notifications
You must be signed in to change notification settings - Fork 957
feat: add string/base/concat #8544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: add string/base/concat #8544
Conversation
Add package to concatenate two strings with fixed arity. This package wraps String.prototype.concat to provide a fixed-arity function that takes exactly two string arguments, unlike the native method which accepts an arbitrary number of arguments. Closes stdlib-js#8520 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Hi! I've completed the implementation for issue #8520 (adding This is my first contribution to stdlib, and I'd appreciate a mentor review to ensure everything follows project conventions. All tests, examples, and benchmarks pass successfully. @kgryte - Could you please review this PR? Thank you! |
Add package to concatenate two strings with fixed arity.
This package wraps String.prototype.concat to provide a fixed-arity function that takes exactly two string arguments, unlike the native method which accepts an arbitrary number of arguments.
Closes #8520
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves #{{TODO: add issue number}}.
Description
This pull request: adds the
@stdlib/string/base/concatpackage to concatenate two strings with fixed arity.The package wraps
String.prototype.concatto provide a fixed-arity function that takes exactly two string arguments, unlike the native method which accepts an arbitrary number of arguments.Related Issues
This pull request has the following related issues:
[RFC]: add
string/base/concat#8520#{{TODO: add related issue number}}
Questions
No.
Other
Implementation Details
lib/node_modules/@stdlib/string/base/concat/concat(str1, str2)- fixed arity (exactly 2 arguments)String.prototype.concatusingstr1.concat(str2)Testing
All tests, examples, and benchmarks have been verified:
ash
✓ make TESTS_FILTER=".string/base/concat." test # 10/10 passing
✓ make EXAMPLES_FILTER=".string/base/concat." examples # All successful
✓ make BENCHMARKS_FILTER=".string/base/concat." benchmark # All passing## Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers