Skip to content

refactor(clippath): replace manual args handling with spread operator #6974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Mohit-Davar
Copy link

Resolves #6956.

Description

This pull request:

  • Refactors the onRender function in ClipPath to use the spread operator (...arguments) instead of manual array creation for emitting events.
  • Also solves linting error.
  • Improves code readability and aligns with modern JavaScript practices.
  • Maintains identical functionality while reducing boilerplate.

Related Issues

This pull request:

Questions

No.

Other

No.


@stdlib-js/reviewers

Signed-off-by: Mohit Davar <mohitdavar2004@gmail.com>
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels May 10, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label May 10, 2025
@kgryte
Copy link
Member

kgryte commented May 10, 2025

@Mohit-Davar Thank you for your interest in stdlib; however, we cannot accept your PR, as the changes you want to introduce are not in line with project conventions. For additional info, see https://github.com/stdlib-js/stdlib/blob/cee6330690f51588e8fc2796f1f928d33d14d9b9/FAQ.md#es2015-and-beyond.

Thanks again, and we look forward to your future contributions.

@kgryte kgryte closed this May 10, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
3 participants