refactor(clippath): replace manual args handling with spread operator#6974
refactor(clippath): replace manual args handling with spread operator#6974Mohit-Davar wants to merge 1 commit intostdlib-js:developfrom Mohit-Davar:fix/clippath-emit-spread-operator
Conversation
Signed-off-by: Mohit Davar <mohitdavar2004@gmail.com>
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
@Mohit-Davar Thank you for your interest in stdlib; however, we cannot accept your PR, as the changes you want to introduce are not in line with project conventions. For additional info, see https://github.com/stdlib-js/stdlib/blob/cee6330690f51588e8fc2796f1f928d33d14d9b9/FAQ.md#es2015-and-beyond. Thanks again, and we look forward to your future contributions. |
Resolves #6956.
Description
This pull request:
onRenderfunction inClipPathto use the spread operator (...arguments) instead of manual array creation for emitting events.Related Issues
This pull request:
Questions
No.
Other
No.
@stdlib-js/reviewers