Skip to content

Add package to convert number of milliseconds to a duration string #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 27, 2022
Merged

Add package to convert number of milliseconds to a duration string #563

merged 7 commits into from
Oct 27, 2022

Conversation

@Planeshifter
Copy link
Member

@Planeshifter Planeshifter commented Oct 26, 2022

Resolves # .

Description

What is the purpose of this pull request?

This pull request:

  • adds a package to convert number of milliseconds a to duration string

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #
  • fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022

Based off the README.md file, the stdlib-bot has generated contents for the ms2duration package and pushed them to the pull request branch.

Notes

  • ⚠️ The stdlib-bot uses AI to generate package content. The generated content is not guaranteed to be correct, and will require manual review and editing. ⚠️

@Planeshifter Planeshifter requested a review from kgryte October 26, 2022 15:34
@Planeshifter
Copy link
Member Author

Planeshifter commented Oct 26, 2022

This package is now ready for review.

@Planeshifter Planeshifter changed the title Add package to convert number of milliseconds a to duration string Add package to convert number of milliseconds to a duration string Oct 26, 2022
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Oct 26, 2022
kgryte
kgryte requested changes Oct 26, 2022
View reviewed changes
@Planeshifter Planeshifter requested a review from kgryte October 27, 2022 19:59
@kgryte kgryte mentioned this pull request Oct 27, 2022
Open
3 tasks
kgryte
kgryte reviewed Oct 27, 2022
View reviewed changes
kgryte
kgryte approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge after all CI jobs pass.

@kgryte kgryte merged commit 0b21908 into develop Oct 27, 2022
@kgryte kgryte deleted the time/ms2duration branch October 27, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

@stdlib-bot stdlib-bot

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Planeshifter @kgryte @stdlib-bot