bench: refactor random number generation in JS benchmarks for stats/b…

[yaswanthkosuru]

Resolves #4982.

Description

What is the purpose of this pull request?

This pull request:

• Refactor random number generation in JS benchmarks for stats/base/dists/pareto-type1

Related Issues

Does this pull request have any related issues?

This pull request:

• resolves [RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/pareto-type1 #4982

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/pareto-type1/cdf	$\color{green}239/239$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}239/239$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/ctor	$\color{green}438/438$ $\color{green}+100.00\%$	$\color{green}32/32$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}438/438$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/entropy	$\color{green}126/126$ $\color{green}+100.00\%$	$\color{green}8/8$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}126/126$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/kurtosis	$\color{green}128/128$ $\color{green}+100.00\%$	$\color{green}8/8$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}128/128$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/logcdf	$\color{green}243/243$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}243/243$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/logpdf	$\color{green}251/251$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}251/251$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/mean	$\color{green}122/122$ $\color{green}+100.00\%$	$\color{green}8/8$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}122/122$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/median	$\color{green}119/119$ $\color{green}+100.00\%$	$\color{green}6/6$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}119/119$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/mode	$\color{green}124/124$ $\color{green}+100.00\%$	$\color{green}8/8$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}124/124$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/pdf	$\color{green}251/251$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}251/251$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/quantile	$\color{green}235/235$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}235/235$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/skewness	$\color{green}196/196$ $\color{green}+100.00\%$	$\color{green}10/10$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}196/196$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/stdev	$\color{green}203/203$ $\color{green}+100.00\%$	$\color{green}12/12$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}203/203$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/variance	$\color{green}129/129$ $\color{green}+100.00\%$	$\color{green}10/10$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}129/129$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[yaswanthkosuru]

@Planeshifter ready for review

[anandkaranubc]

Great work, @yaswanthkosuru. Just some minor changes, otherwise the PR looks good!

[yaswanthkosuru]

@anandkaranubc addressed all changes can you please review.hoping no changes required more.
does make lint doesnt add gaps (ex:like gap between =,small gap after operators ). is there Any other way to do these?

[anandkaranubc]

There still are some changes that are yet to be made based on the review.

[anandkaranubc]

is there Any other way to do these?

Yes, you can call the bot for lint fixes, but relying on it isn't a good practice.

[anandkaranubc]

Suggested change

	len=100;
	len = 100;

[anandkaranubc]

Is EPS needed here?

[anandkaranubc]

Suggested change

	x[ i ] = uniform( EPS, 100.0 );
	x[ i ] = uniform( 0.0, 100.0 );

Same comment as above. If EPS is necessary here, it's fine to keep it. Otherwise, the range should remain the same as original.

[anandkaranubc]

Suggested change

	len=100;
	len = 100;

[anandkaranubc]

Suggested change

	y = mylogcdf( x[ i % len] );
	y = mylogcdf( x[ i % len ] );

[anandkaranubc]

Suggested change

	alpha = 100.56789;
	beta = 55.54321;
	len=100;
	x = new Float64Array( len );
	for ( i = 0; i < len; i++ ) {
	x[ i ] = uniform( EPS, 50.0 );
	}
	mypdf = pdf.factory( alpha, beta );
	alpha = 100.56789;
	beta = 55.54321;
	mypdf = pdf.factory( alpha, beta );
	len = 100;
	x = new Float64Array( len );
	for ( i = 0; i < len; i++ ) {
	x[ i ] = uniform( EPS, 50.0 );
	}

[anandkaranubc]

Suggested change

	}
	b.tic();
	}
	b.tic();