Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for stats/base/dists/uniform/entropy #4021

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

sethdivyansh
Copy link
Contributor

Resolves #3826

Description

  • adds C implementation for @stdlib/stats/base/dists/uniform/entropy along with relevant tests, benchmarks and examples

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 18, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 18, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/uniform/entropy $\color{green}184/184$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}184/184$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title feat: add C implementation for dist/uniform/entropy feat: add C implementation for statse/base/dists/uniform/entropy Dec 19, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sethdivyansh!

Left comments that will have to be addressed before merging, but otherwise looks fine to me.

@sethdivyansh sethdivyansh changed the title feat: add C implementation for statse/base/dists/uniform/entropy feat: add C implementation for state/base/dists/uniform/entropy Dec 19, 2024
@sethdivyansh sethdivyansh changed the title feat: add C implementation for state/base/dists/uniform/entropy feat: add C implementation for stats/base/dists/uniform/entropy Dec 19, 2024
@sethdivyansh
Copy link
Contributor Author

Done with the changes. Please review.

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits!

Made one more change but let's get your PR in now. 🚀

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 19, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 19, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/uniform/entropy`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4021
Closes: https://github.com/stdlib-js/stdlib/issues/3826

Co-authored-by: Divyansh Seth <divyanshseth08@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 4d6fbbd into stdlib-js:develop Dec 19, 2024
28 checks passed
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#4021
Closes: stdlib-js#3826

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/uniform/entropy
3 participants