-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for stats/base/dists/uniform/median
#3970
feat: add C implementation for stats/base/dists/uniform/median
#3970
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts!
The PR currently has a bunch of errors and does not compile. Please test the commands in the linked issue to confirm things work as expected. You also want to make sure you have EditorConfig setup.
lib/node_modules/@stdlib/stats/base/dists/uniform/median/README.md
Outdated
Show resolved
Hide resolved
...les/@stdlib/stats/base/dists/uniform/median/include/stdlib/stats/base/dists/uniform/median.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/median/lib/native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/median/examples/c/Makefile
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/median/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/median/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/median/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/median/test/test.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/median/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
@Planeshifter Make all the changes. Please review all the changes. |
/stdlib lint-autofix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Made a few edits and fixes. Specifically, we want to be consistent with existing terminology (e.g., use "minimum support" and "maximum support" for parameters of continuous uniform distribution) and use the custom random_uniform
to draw randon numbers in the example and benchmark code.
lib/node_modules/@stdlib/stats/base/dists/uniform/median/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/median/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/median/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/median/lib/native.js
Outdated
Show resolved
Hide resolved
...les/@stdlib/stats/base/dists/uniform/median/include/stdlib/stats/base/dists/uniform/median.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/median/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/median/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/median/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/uniform/median/examples/c/example.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
PR-URL: stdlib-js#3970 Closes: stdlib-js#3831 Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: stdlib-bot <noreply@stdlib.io> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: stdlib-js#3970 Closes: stdlib-js#3831 Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: stdlib-bot <noreply@stdlib.io> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Resolves #3831
Description
This pull request:
Related Issues
This pull request:
@stdlib/stats/base/dists/uniform/median
#3831Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers