-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/special/ahavercosf
#3072
Conversation
@Planeshifter ready for review! |
lib/node_modules/@stdlib/math/base/special/ahavercosf/lib/main.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One request regarding the implementation; overall PR looks great! Thanks for your work.
made the required changes, do i also have to add |
@aayush0325 Thanks for the changes! Not needed as a dependency in |
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
i see, @Planeshifter. will keep that in mind, thanks. |
PR-URL: stdlib-js#3072 Closes: stdlib-js#649 Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Resolves #649.
Description
This pull request:
math/base/special/ahavercosf
Related Issues
This pull request:
Questions
No.
Other
Open to reviews!!
Checklist
@stdlib-js/reviewers