Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray API and refactor blas/ext/base/drev #3071

Merged
merged 3 commits into from
Nov 11, 2024
Merged

feat: add C ndarray API and refactor blas/ext/base/drev #3071

merged 3 commits into from
Nov 11, 2024

Conversation

headlessNode
Copy link
Contributor

Description

What is the purpose of this pull request?

This pull request:

  • Adds C ndarray API and refactors blas/ext/base/drev

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 8, 2024
@headlessNode headlessNode marked this pull request as ready for review November 8, 2024 10:49
@headlessNode
Copy link
Contributor Author

Same cppcheck error as other PRs.

Planeshifter
Planeshifter approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not spotting any issues. Let's get this in, thanks @headlessNode!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Nov 11, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C `ndarray` API and refactor `blas/ext/base/drev`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3071

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit ee9a830 into stdlib-js:develop Nov 11, 2024
16 of 17 checks passed
@headlessNode headlessNode deleted the drev-refactor branch November 11, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@headlessNode @stdlib-bot @Planeshifter