Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray API and refactor blas/ext/base/dapxsum #2946

Merged
merged 6 commits into from
Sep 25, 2024
Merged

feat: add C ndarray API and refactor blas/ext/base/dapxsum #2946

merged 6 commits into from
Sep 25, 2024
+342 −133

Conversation

headlessNode
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C ndarray API and code refactor/cleanup to blas/ext/base/dapxsum

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Sep 24, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Sep 25, 2024
@kgryte
Apply suggestions from code review
bb78474 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
526c7a9 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
d48e023 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte kgryte merged commit dc08755 into stdlib-js:develop Sep 25, 2024
10 checks passed
@kgryte kgryte changed the title feat: add C ndarray API and code refactor to blas/ext/base/dapxsum feat: add C ndarray API and refactor blas/ext/base/dapxsum Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@headlessNode @kgryte @stdlib-bot