Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray API to blas/ext/base/sfill #2923

Merged
merged 2 commits into from
Sep 18, 2024
Merged

feat: add C ndarray API to blas/ext/base/sfill #2923

merged 2 commits into from
Sep 18, 2024

Conversation

headlessNode
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C ndarray API and code refactor/cleanup to blas/ext/base/sfill

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Sep 18, 2024
@headlessNode headlessNode changed the title feat: add a C ndarray API to blas/ext/base/sfill feat: add C ndarray API to blas/ext/base/sfill Sep 18, 2024
@kgryte kgryte added C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. labels Sep 18, 2024
kgryte
kgryte approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte kgryte merged commit fd41e1b into stdlib-js:develop Sep 18, 2024
10 checks passed
@headlessNode headlessNode deleted the sfill-c-ndarray branch September 18, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@headlessNode @kgryte @stdlib-bot