Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray implementation for blas/base/sswap and blas/base/dswap #2905

Merged
merged 11 commits into from
Sep 16, 2024
Merged

feat: add C ndarray implementation for blas/base/sswap and blas/base/dswap #2905

merged 11 commits into from
Sep 16, 2024

Conversation

aman-095
Copy link
Member

@aman-095 aman-095 commented Sep 16, 2024 •
edited
Loading

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray APIs for blas/base/sswap.
    • adds C ndarray APIs for blas/base/dswap.
  • updates existing implementations for CBLAS.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Sep 16, 2024
@aman-095 aman-095 changed the title refactor: add C ndarray implementation for blas/base/sswap refactor: add C ndarray implementation for blas/base/sswap Sep 16, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Sep 16, 2024
@kgryte kgryte changed the title refactor: add C ndarray implementation for blas/base/sswap feat: add C ndarray implementation for blas/base/sswap Sep 16, 2024
@kgryte
Apply suggestions from code review
3e1ba3a 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
863e963 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
cae61f4 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
b306633 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

@aman-095
Copy link
Member Author

aman-095 commented Sep 16, 2024 •
edited
Loading

Hey, @kgryte, I'll add the same for dswap here in the same PR.

@kgryte
Copy link
Member

kgryte commented Sep 16, 2024

@aman-095 You want to reuse this PR? Or can I go ahead and merge?

@aman-095
Copy link
Member Author

@kgryte, I will push the changes for dswap in this PR itself, and then you can merge this.

@kgryte
Apply suggestions from code review
14789ba 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
ec0242d 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
d702756 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

@aman-095 aman-095 changed the title feat: add C ndarray implementation for blas/base/sswap feat: add C ndarray implementation for blas/base/sswap and blas/base/dswap Sep 16, 2024
@kgryte kgryte merged commit edcea47 into stdlib-js:develop Sep 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aman-095 @kgryte @stdlib-bot