Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add the missing .ndarray to blas/base/cscal tests for argument validation #2900

Merged
merged 1 commit into from
Sep 15, 2024
Merged

fix: add the missing .ndarray to blas/base/cscal tests for argument validation #2900

merged 1 commit into from
Sep 15, 2024

Conversation

headlessNode
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • add the missing .ndarray to cscal typescript test cases for argument validation

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Sep 15, 2024
@headlessNode headlessNode changed the title fix: add the missing .ndarray to cscal tests for argument validation fix: add the missing .ndarray to blas/base/cscal tests for argument validation Sep 15, 2024
@kgryte kgryte added Tests Pull requests specifically adding tests. TypeScript Issue involves or relates to TypeScript. labels Sep 15, 2024
kgryte
kgryte approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching, @headlessNode!

@kgryte kgryte merged commit 00390b7 into stdlib-js:develop Sep 15, 2024
27 checks passed
@headlessNode headlessNode deleted the fix-cscal branch September 15, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Tests Pull requests specifically adding tests. TypeScript Issue involves or relates to TypeScript.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@headlessNode @kgryte @stdlib-bot