-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use stdlib
equivalent instead of built-in, fix indentation in math/base/special/ldexp
#2781
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
This error in examples comes even without applying the changes in this PR. I'll have a look on |
The error message comes as: example.c:20:10: fatal error: 'stdlib/math/base/special/ldexp.h' file not found
#include "stdlib/math/base/special/ldexp.h" even though the header files looks correct. |
@gunjjoshi Looks like |
lib/node_modules/@stdlib/math/base/special/ldexp/examples/c/example.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
@Planeshifter For other packages too, we do not include the package's path in the |
@gunjjoshi Yeah, the package itself shouldn't be listed as a dependency under its own configuration. I was mistakenly under the impression that the failure was caused in a different package's example. Not clear to me what's going on right now... Also seeing failures loading different modules in the CI checks here. |
@gunjjoshi |
@Planeshifter It doesn't seem we have used that package anywhere in |
We have used |
After looking into this a bit more, I noticed that running the C examples for Running the examples with cc @kgryte |
Description
This pull request:
pow
withstdlib_base_pow
.example.c
.Related Issues
None.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers