Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lapack/base/dlange #2704

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

feat: add lapack/base/dlange #2704

wants to merge 19 commits into from

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Jul 29, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request adds JS implementation for lapack/base/dlange

Related Issues

Does this pull request have any related issues?

Towards #2464

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines.
  • Add tests to test correct value of Forbenius Norm.
  • cleanup base implementation.
  • refactor implementation following dlacpy.

@stdlib-js/reviewers

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. JavaScript Issue involves or relates to JavaScript. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). labels Jul 29, 2024
@Pranavchiku
chore: apply suggestions from code review
c5254fa 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku Pranavchiku marked this pull request as ready for review July 31, 2024 13:23
@Pranavchiku
Copy link
Member Author

Pranavchiku commented Jul 31, 2024 •
edited
Loading

There are a few improvements we can make in this PR, post / in our meet today:

  • replace j,i with i0, i1
  • check correctness of comments in base implementation
  • Add an access variable ( functioning same as dim )

Pranavchiku and others added 2 commits July 31, 2024 23:22
@Pranavchiku
chore: apply suggestion from code review
300e358 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@kgryte
Merge branch 'develop' of https://github.com/stdlib-js/stdlib into pr…
f86215d 
…/Pranavchiku/2704
@Pranavchiku Pranavchiku marked this pull request as draft August 1, 2024 13:36
Pranavchiku and others added 2 commits August 1, 2024 21:07
@Pranavchiku
Merge branch 'dlange' of https://github.com/Pranavchiku/stdlib into d…
316e532 
…lange
@Pranavchiku
chore: apply suggestion from code review
b114224 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku Pranavchiku marked this pull request as ready for review August 2, 2024 14:56
@Pranavchiku
Copy link
Member Author

@kgryte can we please do implementation of access variable in subsequent PRs? This is a major change, I'll prefer to do it in another PR, please.

@kgryte
Copy link
Member

kgryte commented Aug 2, 2024

@Pranavchiku I am not sure the benefit of doing in a follow-up PR. And also, s/access/axis/.

@Pranavchiku Pranavchiku marked this pull request as draft August 3, 2024 06:53
@Pranavchiku
Copy link
Member Author

Done, this PR can have a review now :))

@Pranavchiku Pranavchiku marked this pull request as ready for review August 3, 2024 10:45
@kgryte kgryte added the Needs Review A pull request which needs code review. label Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranavchiku @kgryte