Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blas/base/dtrsm #2518

Open
wants to merge 37 commits into
base: develop
Choose a base branch
from
Open

feat: add blas/base/dtrsm #2518

wants to merge 37 commits into from

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Jul 6, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request adds JS implementation for blas/base/dtrsm ( Level: 3 ). Towards #2464.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

There will be lint errors. I'll polish it once I add other files. I wish that this PR have an initial review to see if direction is correct.

netlib-dtrsm

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

TODO:

  • Either remove fixtures or rename fixture name
  • refactor base implementation to compute general offset outside loop
  • add tests for negative strides
  • update test description
  • fix replt lint error

Checklist

  • Add readme.md
  • Add package.json
  • Add lib
  • Add examples
  • Add ndarray implementation
  • Add docs
  • Add benchmark
  • Add test
  • Refactor implementation

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Pranavchiku Pranavchiku added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jul 6, 2024
@Pranavchiku Pranavchiku mentioned this pull request Jul 6, 2024
Open
@Pranavchiku
Copy link
Member Author

It's been a while I used symbolab

@Pranavchiku
Copy link
Member Author

Pranavchiku commented Jul 8, 2024 •
edited
Loading

A generalisation that I observed while adding examples, row-major upper is column-major upper transpose so, just implement column-major and for row-major, do a transpose that is change transA variable.

@Pranavchiku
Copy link
Member Author

I think we have initial implementation in, although this PR needs to be polished before anyone reviews this. I'll now refactor implementation to decrease nested looping and simplify source code.

@Pranavchiku
chore: apply suggestions from code review
6585a6a 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku Pranavchiku added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Jul 25, 2024
@Pranavchiku
Copy link
Member Author

I think this PR can have a review.

@Pranavchiku Pranavchiku marked this pull request as ready for review July 25, 2024 15:13
@Pranavchiku Pranavchiku added the JavaScript Issue involves or relates to JavaScript. label Jul 25, 2024
@kgryte
Copy link
Member

kgryte commented Aug 1, 2024

@Pranavchiku This PR needs to be updated to remove the order argument from the ndarray method. Also, probably worthwhile looking at the recently merged dtrmv package regarding emerging conventions around descriptions, etc.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Aug 1, 2024
@Pranavchiku Pranavchiku added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranavchiku @kgryte