feat: add C implementation for math/base/special/gamma
#2504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Pranavchiku
reviewed
Jul 5, 2024
Pranavchiku
reviewed
Jul 5, 2024
Pranavchiku
approved these changes
Jul 5, 2024
Member
There was a problem hiding this comment.
This PR looks good, once the changes are done this will be ready to merge. Also the above changes are minor, I am not exactly sure which has higher precision but I think the suggested one has. Here is my discussion with chatGPT, https://chatgpt.com/share/d247d6fe-6321-49b7-a469-a92d0ab38b18
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
math/base/special/gamma.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers