Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add toLocaleString method to array/complex64 #2208

Merged
merged 8 commits into from
May 4, 2024
Merged

feat: add toLocaleString method to array/complex64 #2208

merged 8 commits into from
May 4, 2024

Conversation

Jaysukh-409
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • Adds the typed array toLocaleString method to prototype of Complex64Array

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Apr 27, 2024
@kgryte
Apply suggestions from code review
04e7703 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
6b78dab 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
862a166 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
21117b6 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Apr 27, 2024
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label May 4, 2024
kgryte
kgryte approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Jaysukh-409!

@kgryte kgryte merged commit e92cdd8 into stdlib-js:develop May 4, 2024
8 checks passed
@kgryte kgryte deleted the toLocaleString branch May 23, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaysukh-409 @kgryte