Skip to content

Conversation

@gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Apr 5, 2024

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • Code coverage report:
Screenshot 2024-04-05 at 22 50 21
  • I have followed the function descriptions used in constants/float64/two-pi.

  • Values for reference:

     In [7]: var float64ToFloat32 = require("@stdlib/number/float64/base/to-float32");
    
     In [8]: console.log(float64ToFloat32(6.283185307179586))
     6.2831854820251465
    

    repl was really useful here.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@kgryte
Copy link
Member

kgryte commented Apr 5, 2024

For future reference, you can find out if an alias is available for a particular package by running

In [1]: pkg2alias( '@stdlib/number/float64/base/to-float32' )
'base.float64ToFloat32'

This way you don't have to explicitly require packages which are already available.

@gunjjoshi
Copy link
Member Author

For future reference, you can find out if an alias is available for a particular package by running

In [1]: pkg2alias( '@stdlib/number/float64/base/to-float32' )
'base.float64ToFloat32'

This way you don't have to explicitly require packages which are already available.

Okay, I tried this just now, the alias is already available. Thanks for sharing!

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte merged commit 607aad5 into stdlib-js:develop Apr 5, 2024
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Apr 5, 2024
@gunjjoshi gunjjoshi deleted the float32-two-pi branch April 5, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants