-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/special/acotf
#2117
Conversation
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works well, this looks good, left a question above, once resolved this will be good to merge.
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @gunjjoshi and @Pranavchiku!
Re: tolerance levels. They are within reason, especially given that we are comparing against double-precision implementation. What matters equally is that C and JS tolerances are the same (i.e., the implementations are observationally equivalent), which they are. Thank you, as well, for screenshotting the coverage, as a matter of practice. |
Understood. Thanks, @kgryte @Pranavchiku ! |
Resolves #2113.
Description
This pull request:
math/base/special/acotf
, which is the single-precision equivalent ofmath/base/special/acot
.Related Issues
This pull request:
math/base/special/acotf
#2113.Questions
No.
Other
Since we have used
"inverse cotangent"
inacot
, I have followed the same, instead of using"arccotangent"
.We do need to increase some tolerance, the maximum of which is
1.9 * EPS
. But we get the same tolerance levels for both C and JavaScript versions.Checklist
@stdlib-js/reviewers