feat: add math/base/special/acosf
#2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test Coverage Report: 
|
gunjjoshi
commented
Mar 27, 2024
|
@gunjjoshi Would you mind checking the box in the OP indicating that you've read the contributing guidelines? This needs to be checked in order to confirm that you agree to licensing terms and the Developer's Certificate of Origin. While you've obviously contributed before, we need that confirmation to allow this PR to be merged. |
kgryte
reviewed
Mar 28, 2024
kgryte
reviewed
Mar 28, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Thanks for working on this, @gunjjoshi. I left a couple of comments. My primary thinking is that we should migrate away from Cephes in this case and base our implementation on libm instead.
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
kgryte
reviewed
Apr 2, 2024
kgryte
reviewed
Apr 2, 2024
kgryte
reviewed
Apr 2, 2024
kgryte
reviewed
Apr 2, 2024
kgryte
reviewed
Apr 2, 2024
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2081.
Description
This pull request:
math/base/special/acosf, which is the single precision equivalent formath/base/special/acos.Related Issues
This pull request:
math/base/special/acosf#2081.Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers