Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve math/iter/ops examples #2008

Merged
merged 2 commits into from
Oct 30, 2024
Merged

docs: improve math/iter/ops examples #2008

merged 2 commits into from
Oct 30, 2024

Conversation

domlimm
Copy link
Contributor

@domlimm domlimm commented Mar 23, 2024

Resolves #1575.

Description

What is the purpose of this pull request?

This pull request:

  • Adds examples for methods in math/iter/ops namespace.
  • Updates README.md with the same methods.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 23, 2024
stdlib-bot
stdlib-bot reviewed Mar 23, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@Pranavchiku Pranavchiku added Needs Review A pull request which needs code review. Documentation Improvements, additions, or changes to documentation. labels Mar 25, 2024
@kgryte kgryte changed the title docs(math/iter/ops): improve math/iter/ops README.md examples docs: improve math/iter/ops examples Oct 30, 2024
Planeshifter
Planeshifter approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @domlimm! Simplified and shortened it a little. Will merge shortly.

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Oct 30, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

docs: improve `math/iter/ops` examples

PR-URL: https://github.com/stdlib-js/stdlib/pull/2008
Closes: https://github.com/stdlib-js/stdlib/issues/1575

Co-authored-by: Dominic Lim <dominiclimkj3448@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 43ac1e7 into stdlib-js:develop Oct 30, 2024
17 checks passed
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Nov 9, 2024
@domlimm @Planeshifter @Neerajpathak07
docs: improve math/iter/ops examples
4ea3aa0 
PR-URL: stdlib-js#2008
Closes: stdlib-js#1575

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
@domlimm @Planeshifter @aayush0325
docs: improve math/iter/ops examples
4dd4026 
PR-URL: stdlib-js#2008
Closes: stdlib-js#1575

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Documentation Improvements, additions, or changes to documentation. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: improve README examples of math/iter/ops namespace
4 participants
@domlimm @stdlib-bot @Planeshifter @Pranavchiku