Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for math/base/special/modf #1934

Merged
merged 8 commits into from
Mar 17, 2024
Merged

feat: add C implementation for math/base/special/modf #1934

merged 8 commits into from
Mar 17, 2024

Conversation

gunjjoshi
Copy link
Member

Resolves #1916.

Description

What is the purpose of this pull request?

This pull request:

void stdlib_base_modf( const double x, double* integral, double* frac )

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 17, 2024
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. C Issue involves or relates to C. labels Mar 17, 2024
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, tests fail, @gunjjoshi can you please iterate over implementation again and see where the flaw is, something is off somewhere. Try it, else ping us, will take a close look.

....
      ✖ returns integral part
      ✖ returns fractional part


  total:     10042
  passing:   6036
  failing:   4006
  duration:  391ms

@Pranavchiku Pranavchiku added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 17, 2024
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Copy link
Member Author

Hey @Pranavchiku, all tests pass now. There was an issue after the last commit. Also, I've made changes as suggested. Thanks for pointing them out !

Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @gunjjoshi !

@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 17, 2024
@Planeshifter Planeshifter merged commit 19f6f59 into stdlib-js:develop Mar 17, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the modf branch March 18, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add C implementation for math/base/special/modf
5 participants