-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for math/base/special/modf
#1934
Conversation
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
lib/node_modules/@stdlib/math/base/special/modf/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/modf/examples/c/example.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, tests fail, @gunjjoshi can you please iterate over implementation again and see where the flaw is, something is off somewhere. Try it, else ping us, will take a close look.
....
✖ returns integral part
✖ returns fractional part
total: 10042
passing: 6036
failing: 4006
duration: 391ms
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Hey @Pranavchiku, all tests pass now. There was an issue after the last commit. Also, I've made changes as suggested. Thanks for pointing them out ! |
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @gunjjoshi !
Resolves #1916.
Description
This pull request:
math/base/special/modf
Related Issues
This pull request:
math/base/special/modf
#1916.Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers