Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/asecd #1880

Merged
merged 8 commits into from
Mar 15, 2024
Merged

feat: add C implementation for math/base/special/asecd #1880

merged 8 commits into from
Mar 15, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Mar 14, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_asecd( const double x )

Related Issues

Does this pull request have any related issues?

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@gunjjoshi
feat: add C implementation for math/base/special/asecd
af4641d
@gunjjoshi
feat: add C implementation for math/base/special/asecd
2ee568a
@gunjjoshi
feat: add C implementation for math/base/special/asecd
62a6e3f
@gunjjoshi
Update main.c
50e3e66 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Update main.c
a954273 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Update main.c
9c65a06 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Update main.c
d98b5c3 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@Pranavchiku
chore: apply suggestions from code review
4e3d96d 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 15, 2024
Pranavchiku
Pranavchiku approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @gunjjoshi !

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged. C Issue involves or relates to C. labels Mar 15, 2024
@Planeshifter Planeshifter merged commit f7ec55b into stdlib-js:develop Mar 15, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the asecd branch March 18, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gunjjoshi @Pranavchiku @Planeshifter @stdlib-bot