Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/ssumkbn to follow current project conventions #1741

Merged
merged 2 commits into from
Mar 10, 2024
Merged

refactor: update blas/ext/base/ssumkbn to follow current project conventions #1741

merged 2 commits into from
Mar 10, 2024

Conversation

Snehil-Shah
Copy link
Member

Resolves #1541

Description

What is the purpose of this pull request?

This pull request:

  • refactors update blas/ext/base/ssumkbn to follow current project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Snehil-Shah
refactor: update blas/ext/base/ssumkbn to follow current project co…
8504d97 
…nventions

Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com>
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. labels Mar 6, 2024
@kgryte
Apply suggestions from code review
fa8de74 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks, @Snehil-Shah!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 10, 2024
@kgryte kgryte merged commit 98b0775 into stdlib-js:develop Mar 10, 2024
7 checks passed
@gunjjoshi gunjjoshi mentioned this pull request Mar 13, 2024
Merged
@kgryte kgryte added the Enhancement Issue or pull request for enhancing existing functionality. label Mar 13, 2024
@Snehil-Shah Snehil-Shah mentioned this pull request Mar 29, 2024
Closed
6 tasks
@Snehil-Shah Snehil-Shah deleted the issue1541-refactor-ssumkbn branch April 26, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/ssumkbn to follow current project conventions
3 participants
@Snehil-Shah @kgryte @Planeshifter