-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add string/base/replace-after
#1363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
string/base/replace-after
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Golden <103646877+AuenKr@users.noreply.github.com>
Signed-off-by: Athan <kgryte@gmail.com>
@AuenKr Would you mind updating the copyright years to 2024? Thanks! |
@AuenKr Overall, this PR looks great! Thanks for working on this! |
@AuenKr There's actually one change to this PR that we should make and that is support for The argument should be mandatory (unlike in that discussion), so the expected signature is function replaceAfter( str, search, replacement, fromIndex ) {...} Is this something you can include in this PR? |
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/string/base/replace-after/docs/repl.txt
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/string/base/replace-after/docs/repl.txt
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/string/base/replace-after/test/test.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/base/replace-after/test/test.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AuenKr This looks good. You just need to fix the broken tests, and once finished, this should be ready for merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @AuenKr, and thank you for authoring a clean PR! Will merge once CI successfully completes.
@kgryte, Shouldn't string/base/replace-before also have fromIndex arguement?? |
Signed-off-by: Golden <103646877+AuenKr@users.noreply.github.com>
@AuenKr Yes, it should. |
Resolves #812 .
Description
This pull request:
Related Issues
This pull request:
@stdlib/string/base/replace-after
#812Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers