Skip to content

feat: add reduce method to array/complex64 #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Feb 24, 2024
Merged

feat: add reduce method to array/complex64 #1271

merged 34 commits into from
Feb 24, 2024

Conversation

@Jaysukh-409
Copy link
Member

@Jaysukh-409 Jaysukh-409 commented Jan 15, 2024

Description

What is the purpose of this pull request?

This pull request:

  • Adds the typed array reduce method to prototype of Complex64Array

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Jan 15, 2024
kgryte
kgryte reviewed Jan 15, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 15, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 15, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 15, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 15, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 15, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 15, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 15, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 28, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 28, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 28, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 28, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
f9c9c5c 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jan 28, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
6d2ee68 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jan 28, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 28, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
58fa1c4 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jan 28, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
53b299a 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jan 28, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
199ab19 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jan 28, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 28, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 28, 2024
View reviewed changes
kgryte
kgryte reviewed Jan 28, 2024
View reviewed changes
kgryte
kgryte reviewed Feb 23, 2024
View reviewed changes
kgryte
kgryte reviewed Feb 23, 2024
View reviewed changes
kgryte
kgryte reviewed Feb 23, 2024
View reviewed changes
kgryte
kgryte reviewed Feb 23, 2024
View reviewed changes
kgryte
kgryte reviewed Feb 23, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
856fa92 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte requested changes Feb 23, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @Jaysukh-409. Left a couple of comments for improving the tests. Once resolved, this PR should be ready for merge.

kgryte
kgryte reviewed Feb 24, 2024
View reviewed changes
kgryte
kgryte reviewed Feb 24, 2024
View reviewed changes
kgryte
kgryte reviewed Feb 24, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
f35837f 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
2a48fe9 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Feb 24, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
d087f6b 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Feb 24, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
f5ff8a7 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Feb 24, 2024
View reviewed changes
kgryte
kgryte reviewed Feb 24, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
be872b3 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Feb 24, 2024
View reviewed changes
kgryte
kgryte reviewed Feb 24, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
9529b8e 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Feb 24, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
d94a052 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Jaysukh-409!

@kgryte
Copy link
Member

kgryte commented Feb 24, 2024

I'll merge once CI completes.

@kgryte kgryte merged commit f3def6d into stdlib-js:develop Feb 24, 2024
@kgryte kgryte deleted the reduce branch February 24, 2024 10:33
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jaysukh-409 @kgryte