Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add subarray method to array/complex64 #1217

Merged
merged 8 commits into from
Dec 26, 2023
Merged

feat: add subarray method to array/complex64 #1217

merged 8 commits into from
Dec 26, 2023

Conversation

Jaysukh-409
Copy link
Member

@Jaysukh-409 Jaysukh-409 commented Dec 25, 2023 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

  • Adds the typed array subarray method to prototype of Complex64Array

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Dec 25, 2023
@kgryte
Apply suggestions from code review
b657c8d 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte requested changes Dec 25, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @Jaysukh-409. I left some comments. Currently, this implementation does not behave as expected and the tests are currently insufficient to cover all inputs.

Once these are resolved, we can move this PR forward.

@kgryte
Apply suggestions from code review
468594e 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
bab1529 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
be1f9cd 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
64414ec 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
style: remove empty line
0362924 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Jaysukh-409!

@kgryte kgryte merged commit b9b8916 into stdlib-js:develop Dec 26, 2023
7 checks passed
@kgryte kgryte deleted the subarray branch December 26, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaysukh-409 @kgryte