feat: add forEach method to array/complex64
#1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
reviewed
Dec 24, 2023
kgryte
reviewed
Dec 24, 2023
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 24, 2023
lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.for_each.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 24, 2023
lib/node_modules/@stdlib/array/complex64/benchmark/benchmark.for_each.length.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 24, 2023
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 24, 2023
kgryte
reviewed
Dec 24, 2023
kgryte
reviewed
Dec 24, 2023
kgryte
reviewed
Dec 24, 2023
kgryte
reviewed
Dec 24, 2023
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 24, 2023
kgryte
reviewed
Dec 24, 2023
kgryte
reviewed
Dec 24, 2023
kgryte
reviewed
Dec 24, 2023
kgryte
reviewed
Dec 24, 2023
Comment on lines
150
to
155
| t.deepEqual( reinterpret64( out, 0 ), reinterpret64( out, 0 ), 'returns expected value' ); | ||
| t.end(); | ||
|
|
||
| function fcn( v ) { | ||
| out.push( v ); | ||
| } |
There was a problem hiding this comment.
@Jaysukh-409 I'm not sure what you are trying to test here. I am surprised this test even runs. reinterpret64 is not intended to operate on generic arrays, so providing out does not seem correct.
There was a problem hiding this comment.
And also, reinterpret64( out, 0 ), reinterpret64( out, 0 ) --> I'd expect these two things to be equal. You are testing that out equals out.
kgryte
reviewed
Dec 24, 2023
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 24, 2023
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
requested changes
Dec 24, 2023
There was a problem hiding this comment.
@Jaysukh-409 Thanks for working on this. A test case needs to be updated. Once resolved, should be ready for merge.
kgryte
reviewed
Dec 24, 2023
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 24, 2023
Signed-off-by: Athan <kgryte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
forEachmethod to prototype ofComplex64ArrayRelated Issues
No.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers