feat: add blas/ext/base/ddiff#10376
Open
headlessNode wants to merge 7 commits intostdlib-js:developfrom
Open
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
headlessNode
commented
Feb 19, 2026
lib/node_modules/@stdlib/blas/ext/base/ddiff/benchmark/c/Makefile
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/ddiff/examples/c/Makefile
Outdated
Show resolved
Hide resolved
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
headlessNode
commented
Feb 19, 2026
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
kgryte
reviewed
Feb 24, 2026
kgryte
reviewed
Feb 24, 2026
kgryte
reviewed
Feb 24, 2026
kgryte
reviewed
Feb 24, 2026
kgryte
reviewed
Feb 24, 2026
kgryte
reviewed
Feb 24, 2026
kgryte
reviewed
Feb 24, 2026
kgryte
reviewed
Feb 24, 2026
kgryte
reviewed
Feb 24, 2026
kgryte
reviewed
Feb 24, 2026
kgryte
reviewed
Feb 24, 2026
lib/node_modules/@stdlib/blas/ext/base/ddiff/include/stdlib/blas/ext/base/ddiff.h
Outdated
Show resolved
Hide resolved
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: missing_dependencies
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Member
|
@headlessNode Looks like we are missing some tests needed to get to 100% code coverage. Would you mind adding those? Cheers! |
kgryte
reviewed
Feb 28, 2026
Comment on lines
+174
to
+183
| > {{alias}}.ndarray( x.length, 1, x, 1, 0, 1, p, 1, 0, 1, a, 1, 0, out, 1, 0, w, 1, 0 ) | ||
| <Float64Array>[ 1.0, -3.0, 4.0, 1.0 ] | ||
|
|
||
| // Advanced indexing: | ||
| > var x = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 2.0 ] ); | ||
| > var p = new {{alias:@stdlib/array/float64}}( [ 0.0 ] ); | ||
| > var a = new {{alias:@stdlib/array/float64}}( [ 3.0 ] ); | ||
| > var out = new {{alias:@stdlib/array/float64}}( 3 ); | ||
| > var w = new {{alias:@stdlib/array/float64}}( 3 ); | ||
| > {{alias}}.ndarray( 2, 1, x, 1, x.length-2, 1, p, 1, 0, 1, a, 1, 0, out, 1, 0, w, 1, 0 ) |
Member
There was a problem hiding this comment.
Suggested change
| > {{alias}}.ndarray( x.length, 1, x, 1, 0, 1, p, 1, 0, 1, a, 1, 0, out, 1, 0, w, 1, 0 ) | |
| <Float64Array>[ 1.0, -3.0, 4.0, 1.0 ] | |
| // Advanced indexing: | |
| > var x = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 2.0 ] ); | |
| > var p = new {{alias:@stdlib/array/float64}}( [ 0.0 ] ); | |
| > var a = new {{alias:@stdlib/array/float64}}( [ 3.0 ] ); | |
| > var out = new {{alias:@stdlib/array/float64}}( 3 ); | |
| > var w = new {{alias:@stdlib/array/float64}}( 3 ); | |
| > {{alias}}.ndarray( 2, 1, x, 1, x.length-2, 1, p, 1, 0, 1, a, 1, 0, out, 1, 0, w, 1, 0 ) | |
| > {{alias}}.ndarray( 3, 1, x,1,0, 1, p,1,0, 1, a,1,0, out,1,0, w,1,0 ) | |
| <Float64Array>[ 1.0, -3.0, 4.0, 1.0 ] | |
| // Advanced indexing: | |
| > x = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 2.0 ] ); | |
| > p = new {{alias:@stdlib/array/float64}}( [ 0.0 ] ); | |
| > a = new {{alias:@stdlib/array/float64}}( [ 3.0 ] ); | |
| > out = new {{alias:@stdlib/array/float64}}( 3 ); | |
| > w = new {{alias:@stdlib/array/float64}}( 3 ); | |
| > {{alias}}.ndarray( 2, 1, x,1,1, 1, p,1,0, 1, a,1,0, out,1,0, w,1,0 ) |
Member
There was a problem hiding this comment.
Hopefully, this will resolve the REPL text lint failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves stdlib-js/metr-issue-tracker#163.
Description
This pull request:
blas/ext/base/ddiffRelated Issues
This pull request has the following related issues:
blas/ext/base/ddiffmetr-issue-tracker#163Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers