Description
This commit has 4 comment(s) from core contributors that require attention.
Commit: 1f5d85abbf922cef11f580c053417b61b69c554d
Comments:
-
Line 155: @stdlib-bot Lines L155-158 need to be moved to L250.
stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/README.md
Lines 152 to 158 in 1f5d85a
-
Line 249: @stdlib-bot We are missing a closing
</section>
and trailing comment to pair with the<section class="c">
above. See other similar packages for what we are looking for.stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/quantile/README.md
Lines 246 to 252 in 1f5d85a
-
Line 99: @stdlib-bot These declarations should be ordered by length.
-
Line 50: @stdlib-bot
stdlib_base_sqrt( 2.0 )
should be replaced with https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/constants/float64/sqrt-two. These also applies to the JavaScript implementations. We shouldn't be recomputing this value for each invocation.
Interested in helping improve the project? If you are, the comment linked to above has 4 comment(s) from core contributors that could use your attention.
What do you need to do?
- Open the above linked comments mentioning @stdlib-bot.
- Review the suggested changes or follow-up tasks (e.g., formatting improvements, small refactorings, or clean-up).
- If you are a first-time contributor, follow the contributing and development guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
- Make all the desired changes and commit those changes to a local branch.
- Push the changes to GitHub and open a new pull request against the
develop
branch of the main stdlib development repository.
Once you've opened a pull request, a stdlib maintainer will review your work and suggest any follow-up changes.
And that's it!
Thank you for your help in reducing the project backlog and in improving the quality of stdlib. 🙌
Notes
- For older commits, there is a chance that comments will have been already been addressed due to other refactorings. If you find that to be true, don't worry! Just move on to addressing the next comment, and, when opening your pull request and describing your proposed changes, be sure to link to the comment and mention that it has been addressed. This will help reviewers when reviewing your code!
This issue was created automatically to address commit comments tagging @stdlib-bot.