Description
Description
This RFC proposes improving random number generation in JS benchmarks for stats/base/dists/truncated-normal.
Context: At present, in the remaining packages, random number generation in JS benchmarks occurs inside the benchmarking loop. Since random number generation is an expensive operation, it should be moved out of the benchmarking loops and initialized beforehand to avoid interfering with the results.
When adding support, the following tasks should be completed:
-
Move random number generation out of the benchmarking loops and initialize it before the benchmarks.
-
Ensure that the generated random values use the same range as the existing values to maintain consistency.
-
Use
uniformanddiscreteUniformfrom@stdlib/random/base/uniformand@stdlib/random/base/discrete-uniforminstead ofranduexpressions.- For example, replace
( randu() * 10.0 + EPS )withuniform( EPS, 10.0 ). - Replace
ceil( randu() * 10.0 + EPS )withdiscreteUniform( 1, 10 ).
- For example, replace
To provide a concrete example of what a PR implementing the desired changes should contain, see #4837 and #4955, which provide examples for using both uniform and discreteUniform.
Related Issues
Questions
No.
Other
Once the implementation is complete, you should be able to run the following make commands:
Build Native Add-on
NODE_ADDONS_PATTERN="@stdlib/stats/base/dists/truncated-normal/*" make install-node-addonsRun JavaScript Benchmarks
make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/truncated-normal/*/benchmark/benchmark.js"Run JavaScript Native Benchmarks
make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/truncated-normal/*/benchmark/benchmark.native.js"Note: If running benchmarks results in an error, it is likely due to the random number generators producing values where the functions are not defined. To resolve this, check the relevant benchmark files, adjust the input value ranges to ensure they remain within the domain where the functions are valid, and then rerun the benchmarks. Reference: #4955
Checklist
- I have read and understood the Code of Conduct.
- Searched for existing issues and pull requests.
- The issue name begins with
RFC:.