Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Acorn logs a message to the console when using the REPL #2429

Closed
2 tasks done
kgryte opened this issue Jun 21, 2024 · 0 comments · Fixed by #2430
Closed
2 tasks done

[BUG]: Acorn logs a message to the console when using the REPL #2429

kgryte opened this issue Jun 21, 2024 · 0 comments · Fixed by #2430
Labels
Bug Something isn't working. REPL Issue or pull request specific to the project REPL.

Comments

@kgryte
Copy link
Member

kgryte commented Jun 21, 2024

Description

Encountered an error when using the REPL and performing the following sequence:

In [1]: {<|>

followed by ENTER.

In [1]: {Since Acorn 8.0.0, options.ecmaVersion is required.
Defaulting to 2020, but this will stop working in the future.

When looking through the REPL implementation, I didn't find an instance where we were parsing and not passing options, but it's possible that I missed something.

Related Issues

n/a

Questions

No.

Demo

No response

Reproduction

See OP above.

Expected Results

No response

Actual Results

No response

Version

No response

Environments

Node.js

Browser Version

No response

Node.js / npm Version

No response

Platform

No response

Checklist

  • Read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
@kgryte kgryte added Bug Something isn't working. REPL Issue or pull request specific to the project REPL. labels Jun 21, 2024
@Snehil-Shah Snehil-Shah mentioned this issue Jun 21, 2024
Merged
1 task
kgryte pushed a commit that referenced this issue Jun 22, 2024
@Snehil-Shah
fix: pass options when parsing to suppress warnings in the REPL
d2cd4c3 
PR-URL: #2430
Closes: #2429
Reviewed-by: Athan Reines <kgryte@gmail.com>
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working. REPL Issue or pull request specific to the project REPL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pass options when parsing to suppress warnings in the REPL Snehil-Shah/stdlib
1 participant
@kgryte