feat(auth): add retries to aws boto calls #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the standard boto client defaults to 'legacy' which retries certain HTTP status codes and a limited set of service errors. update retry config to 'standard' which has a broader set of errors/exceptions. in particular it will retry 'TooManyRequestsException' which can be throttled in high burst situations. max retries can be configured by setting the 'STAX_API_AUTH_MAX_RETRIES' environment var.
samdammers
force-pushed
the
boto-retries
branch
from
c95a4e1 to
fc1c8ad
Compare
ZXYmania
reviewed
Aug 17, 2022
add default retries for stax api calls. allow these configuration to be modified by consumers. amended prior boto3 configuration to opt for storing in the Stax config object. marked existing token threshold ENV configuration as deprecated.
samdammers
force-pushed
the
boto-retries
branch
from
337b18c to
fd94b05
Compare
Anton0
previously approved these changes
Sep 6, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #88 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 9 +1
Lines 474 505 +31
=========================================
+ Hits 474 505 +31
|
Anton0
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOKEN_EXPIRY_THRESHOLD_IN_MINSis an outlier in terms of configuring the Stax SDK. marked as deprecated in the README and will be removed in a future release. preference to configure via the Stax Config object (to which the consumer can pass in values as ENV vars should they wish to).