-
Notifications
You must be signed in to change notification settings - Fork 4
feat(sdk): allow for multi config #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7893c41
to
7f79018
Compare
allow each client to have a seperate config
7f79018
to
5a9c04a
Compare
fix unit tests
531bc46
to
e3eda4d
Compare
make clients immutable fix inconsistent default
fix api backwards compatibility
9fdf2c3
to
b4596c0
Compare
increase coverage on unit tests
b4596c0
to
c49a801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good approach to me, I think it'd be nice to have some notes on this in the README.md since auth is normally the first task someone needs to solve to get the SDK up and running, or perhaps an example that shows multiple clients like your PR description.
add an example for how to use a config client
add auth configuration to the readme
revert schema changes
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 436 474 +38
=========================================
+ Hits 436 474 +38
|
allow each client to have a seperate config
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature: allow for each client to have their own config and auth.
What is the current behavior? (You can also link to an open issue here)
Currently all auth and config is globally applied
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Backwards compatibility has been maintained by retaining a global config that can be used in addition to config instances