feat(sdk): remove warrant dependency to remove native dependencies #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfeidau
force-pushed
the
feat_less_dependencies
branch
6 times, most recently
from
a34fa8b to
db2d32f
Compare
ZXYmania
previously approved these changes
Jan 25, 2021
wolfeidau
force-pushed
the
feat_less_dependencies
branch
3 times, most recently
from
00778a9 to
266ab3a
Compare
The SDK currently uses a small part of the https://github.com/capless/warrant library to hand Secure Remote Password (http://srp.stanford.edu/) however this library also provides a number of utility functions for cognito which we don't use. This PR takes just the code we use from warrant and copies it into this SDK, with a header including reference to the library and it's author. This change enables customers to install the SDK on OSX and upload it to lambda and run without the need to recompile native deps in linux containers. fixes #60
wolfeidau
force-pushed
the
feat_less_dependencies
branch
from
266ab3a to
ad774b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 7 8 +1
Lines 329 442 +113
==========================================
+ Hits 329 442 +113
|
Anton0
approved these changes
Jan 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK currently uses a small part of the https://github.com/capless/warrant library to hand Secure Remote Password (http://srp.stanford.edu/) however this library also provides a number of utility functions for cognito which we don't use.
This PR takes just the code we use from warrant and copies it into this SDK, with a header including reference to the library and it's author.
This change enables customers to install the SDK on OSX and upload it to lambda and run without the need to recompile native deps in linux containers.
fixes #60