Skip to content

feat(sdk): remove warrant dependency to remove native dependencies #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

wolfeidau
Copy link
Contributor

The SDK currently uses a small part of the https://github.com/capless/warrant library to hand Secure Remote Password (http://srp.stanford.edu/) however this library also provides a number of utility functions for cognito which we don't use.

This PR takes just the code we use from warrant and copies it into this SDK, with a header including reference to the library and it's author.

This change enables customers to install the SDK on OSX and upload it to lambda and run without the need to recompile native deps in linux containers.

fixes #60

@wolfeidau wolfeidau requested a review from a team as a code owner January 24, 2021 23:37
@wolfeidau wolfeidau force-pushed the feat_less_dependencies branch 6 times, most recently from a34fa8b to db2d32f Compare January 25, 2021 01:06
ZXYmania
ZXYmania previously approved these changes Jan 25, 2021
@wolfeidau wolfeidau force-pushed the feat_less_dependencies branch 3 times, most recently from 00778a9 to 266ab3a Compare January 25, 2021 02:29
The SDK currently uses a small part of the https://github.com/capless/warrant library to hand Secure Remote Password (http://srp.stanford.edu/) however this library also provides a number of utility functions for cognito which we don't use.

This PR takes just the code we use from warrant and copies it into this SDK, with a header including reference to the library and it's author.

This change enables customers to install the SDK on OSX and upload it to lambda and run without the need to recompile native deps in linux containers.

fixes #60
@wolfeidau wolfeidau force-pushed the feat_less_dependencies branch from 266ab3a to ad774b5 Compare January 25, 2021 02:56
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #63 (ad774b5) into master (2609d55) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master       #63    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            7         8     +1     
  Lines          329       442   +113     
==========================================
+ Hits           329       442   +113     
Impacted Files Coverage Δ
staxapp/auth.py 100.00% <100.00%> (ø)
staxapp/aws_srp.py 100.00% <100.00%> (ø)

@wolfeidau wolfeidau merged commit 2c21b5b into master Jan 26, 2021
@wolfeidau wolfeidau deleted the feat_less_dependencies branch January 26, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Cannot load native module 'Crypto.Hash._SHA256'" within Lambda Python3.7
3 participants