Skip to content

refactor (sdk) change the output for the example scripts #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

ZXYmania
Copy link
Contributor

@ZXYmania ZXYmania commented Aug 3, 2020

Have the examples print out the json body rather than just a http code.
Standardise the response by removal of json.dumps

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

@ZXYmania ZXYmania requested a review from a team as a code owner August 3, 2020 01:26
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #56   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          323       323           
=========================================
  Hits           323       323           

Copy link

@rowanu rowanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{}

@ZXYmania ZXYmania merged commit 49dc2b4 into master Aug 4, 2020
@Anton0 Anton0 mentioned this pull request Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants