Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/why-did-you-render: integration and fixes #20

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

stavros-liaskos
Copy link
Owner

No description provided.

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
release-raccoon ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 5:47PM (UTC)

@@ -37,5 +37,5 @@ const Main: React.FunctionComponent<MainProps> = ({ i18n }) => {
</main>
);
};

Main.whyDidYouRender = false;
Copy link
Owner Author

@stavros-liaskos stavros-liaskos Dec 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why-did-you-render will notify as for rerenders of useUser when this is set to true. Same in each component using useUser
Fix is in progress here: auth0/nextjs-auth0#945

@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stavros-liaskos stavros-liaskos merged commit 9c29c76 into master Dec 6, 2022
@stavros-liaskos stavros-liaskos deleted the feat/why-did-you-render branch December 6, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant