Fix: morphTo() not extracting JSON attribute values
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eFromArray() function.
|
Thanks, I'll take a look. |
vinkev
pushed a commit
to vinkev/eloquent-json-relations
that referenced
this pull request
Feb 16, 2022
…eFromArray() function. (staudenmeir#52)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent PR to the framework an edge-case as fixed. It prevented
morphTorelationships to be properly handled if attribute names fortypeandidwhere also registered for casting.Now, instead of trying to access the attribute values via attribute casting, they're accessed directly from the
$attributesarray (viagetAttributeFromArray()).This PR aims to fix a bug caused by the change of attribute value access.