Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable site updates on nightly builds #9994

Merged
merged 1 commit into from
Feb 12, 2020
Merged

re-enable site updates on nightly builds #9994

merged 1 commit into from
Feb 12, 2020

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented Feb 6, 2020 •
edited by StatusWrike
Loading

Since we are re-enabling nightly build updates in https://github.com/status-im/status.im/pull/458 we should also trigger site rebuilds on successful nightly builds.

This also adds wait: false so builds don't fail if there's issue with building the page.

@jakubgs jakubgs added the jenkins label Feb 6, 2020
@jakubgs jakubgs self-assigned this Feb 6, 2020
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Feb 6, 2020 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c60be7d #2 2020-02-06 14:52:34 ~10 min ios 📦ipa 📲
✔️ c60be7d #2 2020-02-06 14:56:40 ~14 min android 📦apk 📲
✔️ c60be7d #2 2020-02-06 14:56:40 ~14 min android-e2e 📦apk 📲

@weekly-digest weekly-digest bot mentioned this pull request Feb 9, 2020
Closed
@jakubgs
re-enable site updates on nightly builds
dc0d0b5 
Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs merged commit dc0d0b5 into develop Feb 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the update-page-nightlies branch February 12, 2020 19:55
@jakubgs jakubgs mentioned this pull request Feb 14, 2020
Merged
@weekly-digest weekly-digest bot mentioned this pull request Feb 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@andremedeiros andremedeiros andremedeiros approved these changes

@cammellos cammellos Awaiting requested review from cammellos

@yenda yenda Awaiting requested review from yenda

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakubgs @status-im-auto @andremedeiros @flexsurfer